encodePubKey util function improvements

[zainen]

Description
addresses with annotations encoded improperly

Steps To Reproduce
https://tezos-dev.slack.com/archives/CNJJ77B9B/p1677682409145329
to hex and back of kt1 address with %annotation does not encode properly and loses annotation

Expected behavior
address should be encoded and decoded without annotation and ideally annotation is not lost and added to the MichelsonV1Expression in the js object

Note: investigate first whether michel-codec already supports contract addresses with %annotations.

[Innkst]

The user solved it using:

let encode_address = s => (
Js.String.slice(~from=0, ~to_=44, s)->encodePubKey,
Js.String.sliceToEnd(~from=44, s)->hex2buf->BufferEx.toNodeBuffer->Node_buffer.toString,
)

[dsawali]

Hey team! Please add your planning poker estimate with Zenhub @AlirezaHaghshenas @hui-an-yang @zainen

[michaelkernaghan]

is the user work around enough is there a fix that has to be applied to the model code?

[zainen]

I believe this work around fully discards the annotation that is with the value

[hui-an-yang]

The naming of function encodePubKey is misleading should be renamed to something like encodeAddress or encodeContract for clarity.
Logic of this function should add a line at the beginning to strip 0x if the input value starts prefix 0x to produce consistent output with or without 0x.
Also this function doesn't deal with kt1 address ends entrypoint name annotation for now, either look to include the logic(michel-codec supports unpacking bytes of smart contract address with annotation) or clarify the limitation in description.