Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the usage of OperationEmitter class in RpcEstimateProvider #2431

Closed
dsawali opened this issue Apr 11, 2023 · 1 comment · Fixed by #2483
Closed

Replace the usage of OperationEmitter class in RpcEstimateProvider #2431

dsawali opened this issue Apr 11, 2023 · 1 comment · Fixed by #2483
Assignees
@dsawali
Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
dev
Milestone
v16.2

Comments

@dsawali
Copy link
Collaborator

dsawali commented Apr 11, 2023

The OperationEmitter class is being extended by a number of Providers and does many things outside of it's intended scope. Refactor the usage of Operation Emitter in RpcEstimateProvider and leverage PrepareProvider where necessary.

Possible approaches:

  • Replace OperationEmitter class with a Provider parent class for these child providers to give basic access to Context
  • Leverage the usage of PrepareProvider in relevant parts of the child providers
@dsawali dsawali mentioned this issue Apr 11, 2023
Closed
4 tasks
@Innkst Innkst added the ga_release Work to be done so we can remove the beta dsignation label Apr 12, 2023
@Innkst Innkst added this to the v16.2 milestone Apr 12, 2023
@dsawali
Copy link
Collaborator Author

dsawali commented Apr 12, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlirezaHaghshenas @hui-an-yang @zainen

@dsawali dsawali added this to To do in dev via automation Apr 14, 2023
@dsawali dsawali moved this from To do to In progress in dev Apr 14, 2023
@dsawali dsawali self-assigned this Apr 14, 2023
@dsawali dsawali mentioned this issue May 16, 2023
Merged
9 tasks
@Innkst Innkst moved this from In progress to Review in progress in dev May 17, 2023
dev automation moved this from Review in progress to Done May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsawali dsawali

Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
dev
  
Done
Milestone
v16.2
Development

Successfully merging a pull request may close this issue.

Replace usage of operation-emitter in favour of the prepare-provider ecadlabs/taquito
2 participants
@dsawali @Innkst