Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs correction (Tezos Domain Lookup Example - TezosDomain => WalletAddress) #2436

Closed
Bug-Reaper opened this issue Apr 16, 2023 · 3 comments · Fixed by #2456
Closed

Docs correction (Tezos Domain Lookup Example - TezosDomain => WalletAddress) #2436

Bug-Reaper opened this issue Apr 16, 2023 · 3 comments · Fixed by #2456
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Milestone

Comments

@Bug-Reaper
Copy link

Description
Doc example code needs a small change. The code example for domain lookup returns the owner address and not the address that the .tez domain points to.

Steps To Reproduce

  1. Visit docs for tezos domains https://tezostaquito.io/docs/tezos_domains/
  2. Scroll to section with example code to lookup a domain

Expected behavior
Example code should do what's described in that section

It is also possible to look up a domain name to find the address it references.

Additional context
You can see pretty clearly it returns the owner for the Tezos Domain. However the owner address is not necessarily the address that the Tezos Domain points to. I believe it should instead return domain.address instead of domain.owner.

@Bug-Reaper Bug-Reaper added the bug Something isn't working label Apr 16, 2023
@Bug-Reaper
Copy link
Author

Bug-Reaper commented Apr 19, 2023

Can someone please confirm that domain.address is the wallet address the tezos domain points towards whereas domain.owner is the wallet address that owns the domain? And that these could be different wallet addresses?

@Innkst Innkst added this to To do in dev via automation Apr 24, 2023
@Innkst Innkst added the documentation Improvements or additions to documentation label Apr 24, 2023
@Innkst Innkst added this to the v16.2 milestone Apr 24, 2023
@zainen
Copy link
Contributor

zainen commented Apr 27, 2023

Hi @Bug-Reaper, yes, the domain.address will point to the address that the name, ie. alice.tez will point to where, as the domain.address is the address that owns that domain name
I believe the usual is the two being the same tz1/2/3/4 address. However, that is not a hard rule; they can be different.

I will update the docs! Thank you

dev automation moved this from To do to Done Apr 28, 2023
@Bug-Reaper
Copy link
Author

Thanks @zainen ! Glad to assist 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
dev
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants