Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaterialNode not rendering items anymore on dev #4330

Closed
BacLuc opened this issue Dec 26, 2023 · 4 comments
Closed

MaterialNode not rendering items anymore on dev #4330

BacLuc opened this issue Dec 26, 2023 · 4 comments
Labels
Bug type: Frontend

Comments

@BacLuc
Copy link
Contributor

BacLuc commented Dec 26, 2023

grafik
@BacLuc
Copy link
Contributor Author

BacLuc commented Dec 26, 2023

May be related to:
grafik
https://ecamp.sentry.io/issues/4762073820/?project=5602507

@manuelmeister manuelmeister self-assigned this Dec 28, 2023
@manuelmeister
Copy link
Member

manuelmeister commented Dec 28, 2023 •
edited
Loading

The bug first occured after 0680cb8.
It seems that the problem comes from changes to the reactivity part of vue, as these parts have not been changed recently and these errors indicate:

Bildschirmfoto 2023-12-28 um 14 24 36 Bildschirmfoto 2023-12-28 um 14 25 01

As I'm not really familiar with the inner workings of the vue reactivity core nor hal-json-vuex, I think it would be sensible if @usu or @carlobeltrame would look at this issue.

@manuelmeister manuelmeister removed their assignment Dec 28, 2023
@usu
Copy link
Member

usu commented Dec 28, 2023

I haven't been able to reproduce locally (in dev mode). Haven't tried in prod/built-mode, yet.

Any of you have been able to reproduce?
@manuelmeister: Where/when did you see the console errors above?

@usu usu mentioned this issue Dec 28, 2023
Merged
@BacLuc
Copy link
Contributor Author

BacLuc commented Apr 27, 2024

fixed with #4342

@BacLuc BacLuc closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug type: Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@usu @BacLuc @manuelmeister