Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade chakra from RC to stable release #131

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

code-jenn-or
Copy link
Contributor

This PR updates Bison to use the latest stable release of chakra-ui from the release candidate version.
All components & templates are updated to reflect the library updates.

Changes

  • Template & Package updates to latest chakra-ui release

Screenshots

(prefer animated gif)

Checklist

  • Requires dependency update?
  • Generating a new app works

Fixes #xxx

@code-jenn-or code-jenn-or requested a review from cball March 24, 2021 16:43
@code-jenn-or code-jenn-or changed the title feat: upgrade chakra from RC to stable release [WIP]feat: upgrade chakra from RC to stable release Mar 24, 2021
@@ -42,8 +42,8 @@
},
"dependencies": {
"@apollo/client": "^3.0.2",
"@chakra-ui/core": "^1.0.0-rc.5",
"@chakra-ui/theme": "^1.0.0-rc.5",
"@chakra-ui/react": "1.3.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version has build error on @chakra/popper dependency that this version does not have

@@ -53,7 +53,9 @@
"apollo-server-express": "^2.18.1",
<% } -%>
"bcryptjs": "^2.4.3",
"cross-fetch": "^3.0.5",
"cross-fetch": "3.0.5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version of cross-fetch creates an issue in the apollo client configuration with the headers.

@code-jenn-or code-jenn-or changed the title [WIP]feat: upgrade chakra from RC to stable release feat: upgrade chakra from RC to stable release Mar 24, 2021
@code-jenn-or code-jenn-or changed the title feat: upgrade chakra from RC to stable release feat:upgrade chakra from RC to stable release Mar 24, 2021
@code-jenn-or code-jenn-or changed the title feat:upgrade chakra from RC to stable release feat: upgrade chakra from RC to stable release Mar 24, 2021
Copy link

@mcavaliere mcavaliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks ❤️ !

@code-jenn-or code-jenn-or merged commit 9ac40bc into canary Mar 30, 2021
@code-jenn-or code-jenn-or deleted the codejenn/upgrade-chakra branch March 30, 2021 19:31
code-jenn-or pushed a commit that referenced this pull request Mar 31, 2021
* feat:upgrade chakra from RC to stable release

* lock cross-fetch version

* lock version of chakra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants