feat: add universal chakra link component #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcavaliere
reviewed
Dec 8, 2021
mcavaliere
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Looks good to me, but ask others who are more active on the project to look as well.
One recommendation: you might want to wrap other clickable components as well for convenience rather than forcing buttons to use the as prop - I did something like this for the CITJS website https://github.com/echobind/jamstack-ebook-website/blob/main/components/Link/index.tsx
|
@mcavaliere Cool idea, I like it 💯 I updated the PR to have a convenience wrapper for |
kgajera
requested changes
Dec 14, 2021
kgajera
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR that completes issue here...
Changes
Linkcomponent for both dynamic and external links compatible with Next.js and Chakra UIascasting (i.e.<Button as={Link} href="/" variant="navigation" />)Checklist