Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing NaN as point coordinates should fail #29

Open
kjeremy opened this issue Jul 18, 2018 · 6 comments
Open

Passing NaN as point coordinates should fail #29

kjeremy opened this issue Jul 18, 2018 · 6 comments

Comments

@kjeremy
Copy link

kjeremy commented Jul 18, 2018

This:

var pointData = {
        type: 'Point',
        coordinates: [NaN, NaN]
    };

passes the range checks but it shouldn't.

@markstos
Copy link
Contributor

@kjeremy: Please contribute a pull request which confirms this case. See an example similar test here: https://github.com/RideAmigosCorp/mongoose-geojson-schema/blob/master/test/GeoJSON.integration.js#L111

@joshkopecek
Copy link
Contributor

@markstos @kjeremy I added in a test for this on the master branch. Can you check?

@markstos
Copy link
Contributor

@joshkopecek Looks good to me. I also see an unrelated warning that the node-growl dependency should be updated due to a security issue.

@kjeremy
Copy link
Author

kjeremy commented Jul 19, 2018

LGTM

@markstos
Copy link
Contributor

I pushed two commits to master which removes the unused supertest dep, which was generating a security warning.

I also updated "mocha", because one of it's deps had a security warning as well.

Releasing soon is not important, as neither dep update affects live code.

@joshkopecek
Copy link
Contributor

@markstos I've pushed an update, tagged v2.1.3

  • Updating mongoose devdep to 5
  • Removing gulp (only used it for jshint and mocha anyway)
  • Fix the local mongoose to use a standard connection string
  • Update mocha to manually exit when done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants