New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Arrow Icon in PullDownContent and ReleaseContent #13

Open

yoshimoto8 opened this issue May 13, 2019 · 1 comment

Labels

yoshimoto8 commented May 13, 2019 •

edited

Hi, I want to remove arrow icon in PullDownContent and ReleaseContent component. Can I create PR?

I think maybe the correction will be like this

interface PullDownContentProps {
  height?: string
  background?: any
  label?: string
  disabled?: boolean
}

export const ReleaseContent: React.SFC<ReleaseContentProps> = ({
  height = '200px',
  background = 'none',
  label = 'Release to refresh'
  disabled = false
}) => (
  <div id="container">
    {disabled ? null : <div id="arrow"/>}
    <span>{label}</span>
  </div>
)

Owner

echoulen commented Jun 27, 2019

looks good

echoulen added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment