Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /lookup/shells return values for assetIds are strange + difference to specifiation on swagger hub #200

Open
MMuellerMitsubishi opened this issue Nov 24, 2023 · 2 comments
Assignees
Labels
Needs: Author Feedback Waiting for information/ feeadback from issue's author question Further information is requested

Comments

@MMuellerMitsubishi
Copy link

When using the GET /lookup/shells method with the Query Parameter "assetIds" with one assetId, the return value is a list of all AAS IDs in the registry. But I expect only one AAS ID as return value.

If I use the query parameter "assetId", the return value is as expected.

Further, when I compare the specification on swagger hub with the implementation in AASX Server there is a difference.
https://app.swaggerhub.com/apis/Plattform_i40/Entire-API-Collection/V3.0.1#/Asset%20Administration%20Shell%20Basic%20Discovery%20API/GetAllAssetAdministrationShellIdsByAssetLink

AASX Server:
image

Swagger Hub Spec:
image

Which of them is correct?

@juileetikekar juileetikekar added the question Further information is requested label Feb 14, 2024
@juileetikekar juileetikekar self-assigned this Mar 14, 2024
@juileetikekar
Copy link
Contributor

Hi @MMuellerMitsubishi,

Could you please provide the "assetIds" and "assetId" input, that you are using, so that we can try to reproduce the issue?

@juileetikekar juileetikekar added the Needs: Author Feedback Waiting for information/ feeadback from issue's author label Mar 14, 2024
@MMuellerMitsubishi
Copy link
Author

Hi @juileetikekar

Use e.g. this Asset ID on the v3security Server: SFRUUDovL1BLLkZFU1RPLkNPTS8zUzdQTTBDUDRCRA

Call for AssetIDs
https://v3security.admin-shell-io.com/lookup/shells?assetIds=SFRUUDovL1BLLkZFU1RPLkNPTS8zUzdQTTBDUDRCRA
Returns array with all AAS IDs in the server

Call for AssetID
https://v3security.admin-shell-io.com/lookup/shells?assetId=SFRUUDovL1BLLkZFU1RPLkNPTS8zUzdQTTBDUDRCRA
Returns the expected AAS ID

According to the spec on swaggerhub only the "assetIds" Paramter exists. The server implements currently both "assetId" and "assetIds". Which one is correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Author Feedback Waiting for information/ feeadback from issue's author question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants