Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Same submodel IDs from different AAS #232

Open
psapel opened this issue Apr 8, 2024 · 2 comments
Open

[Bug]: Same submodel IDs from different AAS #232

psapel opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
Needs: Triage Needs sorting

Comments

@psapel
Copy link

psapel commented Apr 8, 2024

Contact Details

patrick.sapel [ at ] ikv.rwth-aachen.de

Describe the bug

When multiple AAS are equipped with a submodel having the same identifier, the statement /shells/{aasIdentifier}/submodels/{submodelIdentifier} will only retrieve the data from the first AAS on the server that includes this submodel, regardless of the specified aasIdentifier.

Meaning:

  • /shells/AAS-1/submodels/Technical-Data will return all elements from SM Technical-Data of AAS-1 > correct
  • /shells/AAS-2/submodels/Technical-Data will also return all elements from SM Technical-Data of AAS-1 > not correct
  • and so forth

To reproduce and Expected Behaviour

To reproduce, you can use the demo server and the two examples below:
https://v3.admin-shell-io.com/swagger/index.html

  1. AAS SICK_AHM36B_S4QC012x12_1092017
    /shells/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA5MjAxNw/submodels/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ
    or
    aasIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA5MjAxNw
    submodelIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ

Expected value for PROP ManufacturerProductDesignation = AHM36B-S4QC012x12 (correct)

  1. AAS SICK_SIG200_0A0412200_1089794
    /shells/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA4OTc5NA/submodels/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ
    or
    aasIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA4OTc5NA
    submodelIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ

Expected value for PROP ManufacturerProductDesignation = SIG200-0A0412200 (but it displays AHM36B-S4QC012x12 )

Version

https://v3.admin-shell-io.com/swagger/index.html (08.04.2024) and AASX Server V3 2023-11-17.alpha

Thank you for your support!

@psapel psapel added the bug Something isn't working label Apr 8, 2024
@juileetikekar juileetikekar self-assigned this Apr 10, 2024
@juileetikekar juileetikekar added Needs: Triage Needs sorting and removed bug Something isn't working labels Apr 10, 2024
@juileetikekar
Copy link
Contributor

Hi @psapel,

Thank you for raising the issue!

Two different submodels with same identifiers coming from different AAS environments raise some open questions, e.g., if the submodels with already existing identifiers be allowed in the same server. etc.

We will come back to you on this with more information.

@psapel
Copy link
Author

psapel commented Apr 11, 2024

Thank you for quick response @juileetikekar

In my opinion, already existing Submodel identifier should be allowed on the same server as this is more practicable, e.g., for using identic "blueprint" submodels like technical data or nameplate multiple times within different AAS. In addition, it is possible to address a specific submodel uniquely using the combination of AAS-id and the correspondig SM-id.

However, I'm looking forward to your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage Needs sorting
Projects
None yet
Development

No branches or pull requests

2 participants