Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezor/bugfix/fix cannot upate properties #235 #238

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Freezor
Copy link
Contributor

@Freezor Freezor commented Apr 16, 2024

Description

This pull request includes several changes aimed at improving testability, readability, and maintainability of the codebase. It introduces new unit tests for IO.Swagger.Lib.V3 components, refactors existing code to adhere to best practices and design patterns, and removes unused methods to reduce clutter.

Motivation and Context

The motivation behind this pull request is to enhance the overall quality of the codebase by introducing comprehensive unit tests, refactoring complex and redundant code, and ensuring adherence to established design principles. These changes were necessary due to the current state of the code, which has become difficult to maintain and lacks proper test coverage.

Fixes # (issue)

I started this because I tried to fix #235, but it seems that the issue is not on that side of the code, but the issue starts much deeper in the creation of AAS files. But to not loose the changes I created this PR and I still think they are useful.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The changes have been tested extensively using unit tests that cover various components of the IO.Swagger.Lib.V3 project. Additionally, manual testing has been performed to ensure that the refactored code behaves as expected in different scenarios.

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot update non-string properties via REST API
1 participant