Format should respect spaces-for-tabs, editor-tab-width, and Document newline character

[gavinking]

@lucaswerkmeister See com.redhat.ceylon.eclipse.util.Indents which will give you all the things you need.

[lucaswerkmeister]

All of these are already available in FormattingOptions (indentMode, lineBreak), so this is a special case of “setting formatting options from the IDE” (#987). (Although it won’t be in that dialogue.)

[gavinking]

Right, what I mean is that this needs to happen transparently w/o the user doing anything explicit to the formatter. So it's a little distinct from "configuration".

[lucaswerkmeister]

Clarification: What would I do with editor-tab-width? If I indent with tabs, it doesn’t matter – if I indent with spaces, do I use that to determine with how many spaces to indent?

[gavinking]

do I use that to determine with how many spaces to indent?

Yes.

[lucaswerkmeister]

It appears IDocumentExtension4.getDefaultLineDelimiter() (used by Indents, but I’m using it directly so I can tell OS default and explicit \n apart) returns whatever the document currently uses, not what the project’s resource settings specify. Is that okay?

[gavinking]

Yes, that's right.

Sent from my iPhone

On 28 Jun 2014, at 3:04 pm, Lucas Werkmeister notifications@github.com wrote:

It appears IDocumentExtension4.getDefaultLineDelimiter() (used by Indents, but I’m using it directly so I can tell OS default and explicit \n apart) returns whatever the document currently uses, not what the project’s resource settings specify. Is that okay?

—
Reply to this email directly or view it on GitHub.

[lucaswerkmeister]

Great, then I’m ready to push.