Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Metamodel refs to bootstrap modules #2428

Closed
CeylonMigrationBot opened this issue Nov 12, 2015 · 4 comments
Closed

Metamodel refs to bootstrap modules #2428

CeylonMigrationBot opened this issue Nov 12, 2015 · 4 comments

Comments

@CeylonMigrationBot
Copy link

[@tombentley] It seems that the typechecker incorrectly rejects metamodel references to imported bootstrap modules:

print("\`module ceylon.runtime\` is `` `module ceylon.runtime` ``");

Give me "error: module not found in imported modules: 'ceylon.runtime'"

[Migrated from ceylon/ceylon-compiler#2428]

@CeylonMigrationBot
Copy link
Author

[@tombentley] The problem here is that the typechecker does the lookup via packages, and the ceylon.runtime module doesn't contain a ceylon.runtime package. That can be "fixed" by ensuring each of the bootstrap modules has a like-named package. But I'm not sure if they properly addresses interop (do we support getting module metamodels of interop modules @FroMage?)

@CeylonMigrationBot
Copy link
Author

[@FroMage] Seems to me that's just wrong in ExpressionVisitor it should not match by package name but by ModuleImport transitively.

@CeylonMigrationBot CeylonMigrationBot added this to the 1.2.1 milestone Nov 14, 2015
@FroMage FroMage modified the milestones: 1.2.1, 1.2.2 Jan 11, 2016
@FroMage FroMage modified the milestones: 1.2.2, 1.2.3 Feb 18, 2016
@quintesse
Copy link
Contributor

I'm actually inclined to close this issue as invalid, because IMO the ceylon.runtime module should not be considered visible from the code, even if we know it's available in the environment. If you add import ceylon.runtime "x.y.z"; to the module descriptor of the module containing the above code everything works just fine. Wdyt guys? ( @tombentley @FroMage )

@FroMage
Copy link
Contributor

FroMage commented Jul 19, 2016

If it works with the import then yes, this seems invalid, closing.

@FroMage FroMage closed this as completed Jul 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants