Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Stop user from having to recreate registry secret on every Che workspace creation #1572

Open
tetchel opened this issue Dec 17, 2019 · 5 comments
Labels
area/iterative-dev Related to building and deploying applications (AKA "Turbine") kind/enhancement

Comments

@tetchel
Copy link

tetchel commented Dec 17, 2019

It's annoying to have to re-enter my docker registry credentials every time I create a Che workspace. Can we persist it between workspaces with the new design?

@tetchel tetchel added kind/enhancement area/iterative-dev Related to building and deploying applications (AKA "Turbine") labels Dec 17, 2019
@johnmcollier
Copy link
Contributor

johnmcollier commented Dec 17, 2019

What's needed from iterative-dev on this? Wouldn't the persistence need to happen at the IDE level?

@tetchel
Copy link
Author

tetchel commented Dec 17, 2019

in che? where would we persist anything other than on the PV?

@johnmcollier
Copy link
Contributor

johnmcollier commented Dec 17, 2019

D'oh, I missed the Che part. Thought this was for Hybrid.

As it is right now, the secrets are tied to the Che workspace volume, so that if the workspace is stopped, they still exist and are available when the workspace is restarted. The secrets only go away when the workspace is deleted.

I'd be hesitant to keep secrets around on the cluster after the corresponding workspace has gone away. I'd also be hesitant to have new Che workspaces for that user automatically pick up the secrets from previous workspaces.

@tetchel
Copy link
Author

tetchel commented Dec 17, 2019

ok, that makes sense, sounds like we can't get this then?

@johnmcollier
Copy link
Contributor

We can keep this open to see if other folks have thoughts on the matter (I unfortunately am not yet surpreme dictator of Codewind on Che 😉 ).

As it is right now, with Che workspaces being shared between users, I'd be hesitant to support this (especially as Che doesn't provide a good mechanism for workspaces to figure out which user is running the workspace). This could be more useful once Che uses per-user namespaces by default, and everything is nicely isolated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/iterative-dev Related to building and deploying applications (AKA "Turbine") kind/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants