Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

MqttService API break #4170

Closed
davidgraeff opened this issue Aug 31, 2017 · 4 comments · Fixed by #4173
Closed

MqttService API break #4170

davidgraeff opened this issue Aug 31, 2017 · 4 comments · Fixed by #4173

Comments

@davidgraeff
Copy link
Contributor

davidgraeff commented Aug 31, 2017

As we don't have any consumers of the MQTT API right now (they would have been affected by the reconnect bug that just recently got fixed), we should discuss some little API breaks that I strongly recommend:

In MqttBrokerConnection:

  • Rename close() to stop(). The semantic of close is usually, that the object cannot be used anymore. Stop would be matching with start(). Alternatively call start() open() instead.
  • Remove all deprecated methods.

Cheers, David

@maggu2810
Copy link
Contributor

At least me is using the MQTT transport bundle and has been affected by the reconnect bug.
But the changes are okay for me.

@davidgraeff
Copy link
Contributor Author

@maggu2810
Copy link
Contributor

IIRC @kaikreuzer dislike the tcp and ssl prefix.
Does it care which representation paho is using? We are using an abstraction layer, so if we would like to use host, port, useSSL, we could build the paho URL using that three information. If we ever move from paho to another implementation, we could build (using this three information) another URL representation.

@davidgraeff
Copy link
Contributor Author

I changed the url to host+port+secure and removed the name from the connection as well as the textualConfigured flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants