Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Adapt MQTT service to the multi-config concept #5015

Closed
sjsf opened this issue Feb 2, 2018 · 2 comments
Closed

Adapt MQTT service to the multi-config concept #5015

sjsf opened this issue Feb 2, 2018 · 2 comments

Comments

@sjsf
Copy link
Contributor

sjsf commented Feb 2, 2018

With #4685 we now have a concept implemented which allows configuring the same type of service multiple times. Therefore it would make sense to adapt the MqttService to making use of it, as it is a perfect example of such a service.

The currently open PR #4173 addresses the same topic (together with several other refactorings) in a different way. I'm not sure what makes more sense, including it in #4173 or doing this separately and then adapt #4173.
@kaikreuzer
Copy link
Contributor

@davidgraeff As you worked heavily on the referenced MQTT, do you have any opinion on this?

@davidgraeff
Copy link
Contributor

Done. @SJKA @kaikreuzer

@sjsf sjsf closed this as completed Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidgraeff @sjsf @kaikreuzer