Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I test PCL plugin for the artifacts from PR 1531? #1540

Open
daverch opened this issue Jan 10, 2024 · 1 comment
Open

How do I test PCL plugin for the artifacts from PR 1531? #1540

daverch opened this issue Jan 10, 2024 · 1 comment

Comments

@daverch
Copy link

daverch commented Jan 10, 2024

Hi there,

I’m working on improving parts of BIRT’s more or less internal code, see
#1531

(This is meant for preparing JS script support for ExtendItems like RotatedText as a next step, but that’s a different topic).
What I did in PR 1531 was to add types to dozens of collections arguments and variables, e.g. List instead of just List.

I guess the only place this could have a negative impact is when using plugins.

So I’m asking:

Does anybody on the list develop or use custom plugins (except RotatedText) or know someone who does?

It would be nice if anyone could test if the code changes from PR 1531 cause any problems for such plugins.

I don’t think this will be a problem, but it would be good to be sure before merging.

Mit freundlichen Grüßen
Henning von Bargen

My PCL files are attached.
com.u2logic.xlr8.reporter.emitter.pcl.feature.zip

@daverch
Copy link
Author

daverch commented Jan 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant