Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging column widths with the mouse working "opposite direction" #629

Closed
hvbargen opened this issue Apr 1, 2021 · 3 comments
Closed
Assignees
Milestone

Comments

@hvbargen
Copy link
Contributor

hvbargen commented Apr 1, 2021

This is quite hard to explain with words.
Say you have created a new 2-column table item.
If you try to drag the column widths with the mouse to make e.g. the first column ca. 3 cm wide, this results in the first column having a width of (available-width - 3 cm).

This did not happen in BIRT 4.2.1.
OTOH, in BIRT 4.2.1, dragging the column width of any column caused every column to have a fixed width - and the table as a whole, too.
Now, in the 2-column example, the second column has no specified width - which is good.
When coaching, I always tell users to not use the mouse to set column widths, because I think it's usually much better if the table and at least one column do not have a specified width. With newer BIRT releases, this recommendation is no longer as important as before.

I guess this issue and the changed behavior in comparison to 4.2.1 are closely related.

I'll try to fix this myself after I'll have created PRs for some other bugs.

@hvbargen
Copy link
Contributor Author

hvbargen commented Apr 4, 2021

I reckon the issue is caused by a change in 7dd84fd in file ColumnDragTracker.java.
I'll try to fix this.

@hvbargen
Copy link
Contributor Author

hvbargen commented Apr 4, 2021

The fix for this bug is included in #630 - I forgot to create a new branch and a new PR.

@wimjongman
Copy link
Contributor

Please create separate PR's in the future.

@wimjongman wimjongman added this to the 4.9 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants