Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.apache.commons:commons-compress to 1.26.2 #323

Merged
merged 1 commit into from
May 24, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented May 24, 2024

No description provided.

@ghentschke
Copy link
Contributor

Why is this update needed?

@merks
Copy link
Contributor Author

merks commented May 24, 2024

I'm not sure about need. Maybe it doesn't even need to be in the target platform? Better to remove it then.

It's just the case that a new version is available, other projects will use this new version, and we generally try to avoid "duplicates" in SimRel whenever possible.

https://github.com/eclipse-simrel/.github/blob/main/wiki/SimRel/Simultaneous_Release_Requirements.md#re-use-and-share-common-third-party-code-partially-tested

Additionally we try to use the latest release of all 3rd party dependencies:

https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html

//cc @jonahgraham

eclipse-cdt/cdt#799

@jonahgraham
Copy link
Member

As we try to keep the CDT and CDT-LSP target platform in sync and I accepted eclipse-cdt/cdt#799 I will do the same here.

For the why is this in our dependencies, I think it is (or once was) a transient dependency. Feel free to check if it is still actually needed and remove it from here and CDT's copy.

@jonahgraham jonahgraham merged commit 58c1021 into eclipse-cdt:master May 24, 2024
3 checks passed
@merks
Copy link
Contributor Author

merks commented May 24, 2024

Probably it's transitively pulled in by docker dependencies:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants