Make CodanRunner progress monitor work a bit better #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkZ3
force-pushed
the
CodanRunnerProgressMonitor
branch
from
510ebb7
to
3e4fb7c
Compare
The progress monitor didn't show which file was being analyzed properly. Also, the work units didn't seem to be counted in a good way because the progress bar would stay stuck at like 1%. The fix in this commit for that is not perfect as it gives equal weight to all resources on a same level until further split into sub monitors. It still works quite a bit better without requiring more heavy changes. Also fix usage of deprecated SubProgressMonitor.
MarkZ3
force-pushed
the
CodanRunnerProgressMonitor
branch
from
3e4fb7c
to
34a7a2c
Compare
|
Thanks @MarkZ3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress monitor didn't show which file was being analyzed properly.
Also, the work units didn't seem to be counted in a good way because the progress bar would stay stuck at like 1%. The fix in this commit for that is not perfect as it gives equal weight to all resources on a same level until further split into sub monitors. It still works quite a bit better without requiring more heavy changes.
Also fix usage of deprecated SubProgressMonitor.