Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Authentication for Git repositories #2283

Merged
merged 50 commits into from
May 11, 2022
Merged

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Apr 12, 2022

What does this pull request change

What issues does this pull request fix or reference

RHDEVDOCS-3791
eclipse-che/che#21298

Specify the version of the product this pull request applies to

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

max-cx and others added 30 commits December 7, 2021 18:10
…a-workspace.adoc

Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
…lone-of-a-git-repository.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
…lone-of-a-git-repository.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
…for-starting-a-new-workspace.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@themr0c themr0c moved this from In progress to Drafts in Reviews May 4, 2022
@max-cx max-cx marked this pull request as ready for review May 4, 2022 09:51
@max-cx max-cx requested review from rkratky, themr0c and a team as code owners May 4, 2022 09:51
@max-cx max-cx requested review from nickboldt and removed request for a team May 4, 2022 09:51
@che-bot che-bot moved this from Drafts to Triage in Reviews May 4, 2022
@max-cx
Copy link
Contributor Author

max-cx commented May 4, 2022

Preview:

image

image

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-cx Left a comment. Nitpick. Otherwise, LGTM. Thanks!

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-cx Thanks for the changes. Approved!

@Srivaralakshmi
Copy link
Contributor

/lgtm

Reviews automation moved this from Triage to Approved May 4, 2022
Copy link
Contributor

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than failing build, LGTM

@themr0c themr0c merged commit 08c0d14 into eclipse-che:master May 11, 2022
Reviews automation moved this from Approved to Done May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Reviews
  
Done
5 participants