Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail che-machine-exec with help log.fatal, log and send critical messages to the client. #23

Open
AndrienkoAleksandr opened this issue Feb 27, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AndrienkoAleksandr
Copy link
Contributor

No description provided.

@AndrienkoAleksandr AndrienkoAleksandr added enhancement New feature or request good first issue Good for newcomers labels Feb 27, 2019
@Avni-Sharma
Copy link

Hi there? What is this issue trying to convey? Isn't it being catered in #21 ?

@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Feb 27, 2019

#21 covered case, when Eclipse CHE workspace could not start if che-machine-exec detected bad infra.
For this current issue we need to remove log.fatal for other places of the code. I think if che-machine exec could not work - it's a bad, but it's not a reason to fail workspace in runtime. So I think it would be nice to replace log.fatal to simply log with error notification.

@Avni-Sharma
Copy link

Does it mean replacing the log.Fatal in namespace_provider.go and main.go?

@AndrienkoAleksandr
Copy link
Contributor Author

Does it mean replacing the log.Fatal in namespace_provider.go and main.go?
@Avni-Sharma , Sorry for delay. Yes, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants