Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lsp][plug-in] Ease the integration of a new LSP into Eclipse Che with plug-ins #10206

Closed
4 tasks
benoitf opened this issue Jun 27, 2018 · 6 comments
Closed
4 tasks
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@benoitf
Copy link
Contributor

benoitf commented Jun 27, 2018

Description

Eclipse Che is becoming more and more extensible and customizable.

Workspace.next engine is allowing to plug new tool container into the workspace
Theia and plug-in model is allowing an easy way to plug new IDE components as well. (instead of Theia extension)

Goal of this epic is to get advantages of these two when we talk about LSP implementations.

Plug-in's model API should provide LSP plug-ability for the client side. (like the textmate configuration, the lsp options, etc)
Definition of the container providing LSP server should be a workspace.next configuration.

All of this should be then packaged as a Che Plugin.

Tasks

  • define LSP Theia plug-in API
  • check workspace.next configuration with a plugin
  • documentation on writing Che plugin with ws.next part + theia plugin.
  • video demo of this e2e flow.
@benoitf benoitf added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Jun 27, 2018
@tsmaeder
Copy link
Contributor

tsmaeder commented Jun 27, 2018

define LSP/theia API (it could be che API if specific to Eclipse Che)

Please no! Let's keep make it so that we can take any lsp, package it in a container and then run it as a che plugin. Special Che API would be counter to that goal.

@benoitf
Copy link
Contributor Author

benoitf commented Jun 27, 2018

@tsmaeder how do you will bring syntax highlight and other stuff ?
also "what kind of sabotage" are you seeing ?
AFAIK today there is IDE plugin for each language on Che.

@tsmaeder maybe you need to edit as well your comment because it looks like it's only a "inline quote of myself"

@tsmaeder
Copy link
Contributor

Maybe I don't get it: there is already api to contribute syntax highlighting in Theia. Why would we add something incompatible?

@benoitf
Copy link
Contributor Author

benoitf commented Jun 27, 2018

@tsmaeder I don't know if you read too quickly but it would be only if there is something specific to che that we could require a Che API (like grabbing the url of a container, getting some container metadata, or anything else specific due to Che and Theia integration).

Also AFAIK for now syntax highlighting is through extension not plug-in model.

to sum-up, goal is more to provide Theia "plug-in" model to LSPs.

@benoitf
Copy link
Contributor Author

benoitf commented Jun 27, 2018

@tsmaeder I've updated the description of the issue

@benoitf benoitf changed the title [lsp][plug-in] Ease the integration of a new LSP into Eclipse Che [lsp][plug-in] Ease the integration of a new LSP into Eclipse Che with plug-ins Jun 27, 2018
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@benoitf benoitf closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants