Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory and stack features are not supported in Workspace.Next #10368

Closed
garagatyi opened this issue Jul 10, 2018 · 4 comments
Closed

Factory and stack features are not supported in Workspace.Next #10368

garagatyi opened this issue Jul 10, 2018 · 4 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@garagatyi
Copy link

Description

Right now Workspace.Next using workspace attributes to store a list of Che features. But we don't have attributes in the Factory object, so can't use Factory with Workspace.Next for the time being.
We need to find a way to add Workspace.Next capabilities to factories. Would be awesome to have it in walking skeleton #10123.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 10, 2018
@garagatyi
Copy link
Author

@slemeur since you are a known Factory and Workspace.Next fan here is something you might be interested in!

@garagatyi
Copy link
Author

After the discussion with Florent, Anna, Sergii, Serhii, and Yevhen we decided to add an attributes field to the workspace config model object. This to make our workspace model object contains two fields with the same name - one on the whole workspace level and another one on the workspace config level.
We also decided that attributes from config won't be added to the whole workspace attributes to not bring more confusion.
This solution would allow us to have walking skeleton stuff in both Factory and Stack.
We also mentioned that solution might be temporary since, eventually, we will add che editor and che plugins fields in the workspace model directly. So, it might make sense to mark this field with Beta annotation or so.

@garagatyi
Copy link
Author

We will also need to verify that both stack and factory can launch walking ws.next workspace as part of this task.

@garagatyi garagatyi changed the title Factory feature doesn't support Workspace.Next Factory and stack features are not supported in Workspace.Next Aug 7, 2018
@slemeur
Copy link
Contributor

slemeur commented Aug 7, 2018

That will have to be mentioned in the documentation about the (new) workspace model.

@sleshchenko sleshchenko self-assigned this Aug 9, 2018
@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 9, 2018
@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

3 participants