Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspace-loader (or UD) show an error received from websocket on workspace start failure #10540

Closed
garagatyi opened this issue Jul 25, 2018 · 2 comments · Fixed by #10688
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@garagatyi
Copy link

Description

When workspace start fails after some time workspace-loader and UD receive the message with the error, but provide UX that might be not clear to some users:

  • There is a red circle near the workspace name
  • There is no error shown
  • The workspace loading progress bar doesn't disappear that might make a user think that workspace is still starting

Instead of that, it would be nice to:

  • stop showing the progress bar
  • show a popup with the error message and a button to restart the workspace (the same as reloading the page)

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added kind/bug Outline of a bug - must adhere to the bug report template. team/ide2 labels Jul 25, 2018
@garagatyi
Copy link
Author

@slemeur @ashumilova I decided to label this issue as a bug since it is about confusing UX when a user might not understand that workspace start failed and nothing will happen.
But feel free to relabel it as a task if you think otherwise.

@slemeur
Copy link
Contributor

slemeur commented Jul 28, 2018

ok thanks @garagatyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants