Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up branches in Che Theia hosted plugin extension #10808

Closed
sunix opened this issue Aug 16, 2018 · 10 comments
Closed

Clean up branches in Che Theia hosted plugin extension #10808

sunix opened this issue Aug 16, 2018 · 10 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@sunix
Copy link
Contributor

sunix commented Aug 16, 2018

Description

At the moment, https://github.com/eclipse/che-theia-hosted-plugin-manager-extension has 3 branches and it is very confusing which branch to use. The goals of this issue are

  1. to have only one used branch: master.
  2. use this one in the Che Theia docker image: https://github.com/eclipse/che/blob/master/dockerfiles/theia/src/extensions.json#L34
        ...
        },
        {
            "name": "@eclipse-che/che-theia-hosted-plugin-manager-extension",
            "source": "https://github.com/eclipse/che-theia-hosted-plugin-manager-extension.git",
            "checkoutTo": "latest-deps",
            "type": "git"
        },
        {
        ....
    
  3. make sure that everything is working fine after theses changes
@sunix sunix added kind/enhancement A feature request - must adhere to the feature request template. team/ide2 labels Aug 16, 2018
@sunix sunix changed the title Clean up branches in Che Theia hosted pluging extension Clean up branches in Che Theia hosted plugin extension Aug 16, 2018
@mmorhun mmorhun self-assigned this Aug 29, 2018
@mmorhun
Copy link
Contributor

mmorhun commented Aug 29, 2018

@sunix this is problem of the extension, not Che. Please, next time let's create such issues in appropriate repository.

@sunix
Copy link
Contributor Author

sunix commented Aug 30, 2018

@mmorhun
AFAIK we create issue related to Che in the che github issue tracker.

To me all the extensions that will be included to Che product should have their issue created in a single github issue repo.

@mmorhun
Copy link
Contributor

mmorhun commented Aug 30, 2018

@sunix IMO, if the code is core part of Che it should be in Che repo, not somewhere else (obviously che parent, deps and docs are exceptions). If not - it is a separate repository with own issues.
Taking into account workspace next features, Theia is just an option. And I have doubts about creating option's plugin(s) issues in main Che repo.

@sunix
Copy link
Contributor Author

sunix commented Aug 30, 2018

What do you mean by "core" part ... it in Che by default or not. This is going to Che default packaging so it makes sense that it is in Che. Let's discuss about that during next Che dev meeting.

@mmorhun
Copy link
Contributor

mmorhun commented Aug 30, 2018

By core I mean things which is required for Che and without them Che isn't usable.

@sunix
Copy link
Contributor Author

sunix commented Aug 30, 2018

So none of the ui part part is part of core, as some of our customer use Che without our UI. We can use Che with openshift so docker support is not part of Che core. It doesn't make sense. Che is all the features we provide in Che product.

@mmorhun
Copy link
Contributor

mmorhun commented Aug 30, 2018

No it makes sense. Just current approach is different. And I agree that statement with only core doesn't suite it. My point is that, issue should be near related code. In this very case it is not true. Why should one create an issue in one repository to fix something in another. Does it make sense?

@sunix
Copy link
Contributor Author

sunix commented Aug 30, 2018

You can send a mail to che-dev about that and/or add a topic to the next che-dev community meeting. The rule is, at the moment, to create issues related to Che, part of Che and maintained by Che developers into one Che Github repo. This has been here before the acquisition ...

@mmorhun
Copy link
Contributor

mmorhun commented Aug 30, 2018

Yes it should be discussed in wider audience.
As about rule. That times, conditions were different...
And AFAIK that rule was on spot decision in our team (at least) because structure wasn't clear.

@mmorhun
Copy link
Contributor

mmorhun commented Sep 3, 2018

Done

@mmorhun mmorhun closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

2 participants