Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theia][Plugin]Rework Task extension to Task plugin #11458

Closed
23 of 24 tasks
vparfonov opened this issue Oct 3, 2018 · 4 comments
Closed
23 of 24 tasks

[Theia][Plugin]Rework Task extension to Task plugin #11458

vparfonov opened this issue Oct 3, 2018 · 4 comments
Assignees
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Oct 3, 2018

The existing https://github.com/eclipse/che-theia-task-plugin is developed based on the existing extensibility model in Theia IDE. But as far as new plugin model is on it's way and will be used in Che as the main one - there is need to rework Task extension to Task plugin.

P.S.: add subtask here if need

Missing Theia Plugin APIs to implement:

To implement Task plugin features progressively we can implement it in the following order:

  • once the tasks.registerTaskProvider API is done
    • implement providing the Che workspace commands as Theia tasks
  • once the che.registerTaskRunner API is done
    • implement CheTaskRunner for running the tasks via machine-exec server
  • once the che.registerVariableProvider API is done
    • implement resolving the variables in a Che task
    • add VariableProvider for resolving server's address by name, e.g.: ${server.tomcat}
  • once the tasks.onDidStartTask API and Terminal API is done
    • make it possible to connect to machine-exec container to show a task's output
    • implement Preview URL functionality(info message with ability to open preview URL in the preview widget of Thea project or in a new tab of browser)
  • once ability to specify container for webview panel is done
    • implement widget for displaying list of preview URLs (server name ---> Preview button ---> Go to button) and ability to display it from status bar item
  • once the 'tasks.taskExecutions' API is done
    • add ability to display preview URL for running tasks
  • once ability to get current selection in the explorer view is done
  • once Theia Terminal plugin is done
    • switch task's output from output channel to terminal widget
  • once Webview API is improved
    • improve way of updating previews widget
@vparfonov vparfonov added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels Oct 3, 2018
@azatsarynnyy
Copy link
Member

After analyzing the che-theia-task-extension sources I see the following steps are required to start reworking the extension as a plug-in:

Terminal

In order to show a task output I guess the che-theia-terminal-extension need to be reworked into a plug-in and it should provide some API to connect to machine-exec server.

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Nov 15, 2018

@azatsarynnyy
Copy link
Member

I've updated the description with the subtasks.

@slemeur slemeur mentioned this issue Dec 11, 2018
69 tasks
@RomanNikitenko RomanNikitenko self-assigned this Dec 27, 2018
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 27, 2018
@slemeur
Copy link
Contributor

slemeur commented Jan 4, 2019

How are we doing on this issue and what's remaining? is the task list in the issue description up to date?

@l0rd l0rd mentioned this issue Feb 19, 2019
@vparfonov vparfonov added Epic and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Feb 25, 2019
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 6, 2019
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 14, 2019
@slemeur slemeur added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed Epic labels Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

5 participants