Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to disable discover-ability of a plugin endpoint #11606

Closed
garagatyi opened this issue Oct 12, 2018 · 0 comments · Fixed by #11617
Closed

Add an ability to disable discover-ability of a plugin endpoint #11606

garagatyi opened this issue Oct 12, 2018 · 0 comments · Fixed by #11617
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@garagatyi
Copy link

Description

We use server discovery to be able to provide a seamless pluggability for Che 7 sidecars. On k8s/OS infras it is based on k8s Service. Which mean that Che plugin endpoint name has to be a valid k8s Service name. Since Che plugin endpoint names are allowed to include characters not allowed in k8s Service name we can't create a k8s Service for such Che plugin endpoint.
Since it is needed to start classic Che GWT IDE and it doesn't need service discovery at the moment we can add server attribute discoverable=false that would inform Che that we don't need to create k8s service with an equal name for a Che plugin endpoint and we won't have an incompatibility issue.
To implement that for Workspace.Next flow where service discovery is implemented we can add a check here whether we the endpoint has attribute discoverable and whether the value is false. And if so, do not create a k8s service for such an endpoint.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Oct 12, 2018
@garagatyi garagatyi changed the title Add an ability to disable discover-ability of a server Add an ability to disable discover-ability of a plugin endpoint Oct 12, 2018
@l0rd l0rd mentioned this issue Oct 12, 2018
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant