Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An ability to specify Kubernetes/OpenShift List as tool in Devfile #11906

Closed
sleshchenko opened this issue Nov 12, 2018 · 1 comment
Closed
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Nov 12, 2018

Description

To start quicker it was decided to start with Devfile that will contain editor and plugins only.
But it is needed to add an ability to specify workspace environment in Devfile.
This issue is about changing Devfile model to be able to handle Kubernetes/OpenShift tool.

# An example of Devfile with Kubernetes/OpenShift tool specified
---
specVersion: 0.0.1
name: petclinic-dev-environment
projects:
  - name: petclinic
    source:
      type: git
      location: 'git@github.com:spring-projects/spring-petclinic.git'
tools:
  - name: petclinic-app
    type: kubernetes
    local: petclinic-app.yml
  - name: theia-ide
    type: cheEditor
    id: eclipse/theia:0.0.3
  - name: jdt.ls
    type: chePlugin
    id: eclipse/theia-jdtls:0.0.3
commands:
  - name: run
    actions:
      - type: exec
        tool: petclinic-app
        command: `./catalina.sh start`
        workdir: /home/user/app/tomcat

Note that this issue is only about Devfile model changes to be able to handle kubernetes/openshift tool.
DevfileService#createWorkspaceFromYaml and DevfileService#createFromWorkspace methods won't support kubernetes/openshift tool since it contains relative link to tool configuration file (at least for time being).
kubernetes/openshift tool will be supported by Factory workflow when workspace is created from repository inside of repository, the following issue #12266.

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Nov 12, 2018
@slemeur slemeur mentioned this issue Dec 20, 2018
69 tasks
@sleshchenko sleshchenko changed the title An ability to specify workspace environment in Devfile An ability to specify Kubernetes/OpenShift List as tool in Devfile Dec 22, 2018
@sleshchenko
Copy link
Member Author

The issue is updated to support Kubernetes/OpenShift List as tool in Defile. The separate issue should be created for supporting dockerimage tool by Devfile.

@mshaposhnik mshaposhnik self-assigned this Dec 28, 2018
@mshaposhnik mshaposhnik added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 28, 2018
@mshaposhnik mshaposhnik removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

2 participants