Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of dockerimage tool in Devfile #12389

Closed
sleshchenko opened this issue Jan 11, 2019 · 6 comments
Closed

Add support of dockerimage tool in Devfile #12389

sleshchenko opened this issue Jan 11, 2019 · 6 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Jan 11, 2019

Description

Add support of dockerimage tool in Devfile.
dockerimage tool format should allow to specify dockerimage like (eclipse/che-server:nightly) and Che specific fields for defining volumes, servers, env vars, etc. See the following example of possible format

---
version: 0.0.1
name: petclinic-dev-environment
projects:
  - name: petclinic
    source:
      type: git
      location: 'git@github.com:spring-projects/spring-petclinic.git'
tools:
  - name: maven
    type: dockerimage
    image: maven:3.5.4-jdk-8
    volumes:
      - name: maven-repo
        containerPath: /root/.m2
    env:
      - name: ENV_VAR
        value: value
    endpoints:
      - name: maven-server
        port: 3101
        attributes: 
          protocol: http
          secure: true
          public: true
          discoverable: false
    memoryLimit: 1500M
    mountSources: true
  - name: theia-ide
    type: cheEditor
    id: eclipse/theia:0.0.3
  - name: maven-sidecar
    type: chePlugin
    id: eclipse/maven-sidecar:0.0.3
commands:
  - name: build
    actions:
      - type: exec
        tool: maven
        command: mvn package
        workdir: /projects/spring-petclinic

The format should be sync with che-plugin.yaml format. See Plugin Java Model, che-plugin.yaml example

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Jan 11, 2019
@sleshchenko sleshchenko self-assigned this Feb 6, 2019
@sleshchenko sleshchenko added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Feb 6, 2019
@sleshchenko
Copy link
Member Author

@garagatyi @l0rd @skabashnyuk Are you OK with proposed model (see issue description) for dockerimage tool?

@garagatyi
Copy link

Looks good to me

@l0rd
Copy link
Contributor

l0rd commented Feb 6, 2019

LGTM too

@slemeur slemeur mentioned this issue Feb 6, 2019
69 tasks
@sleshchenko
Copy link
Member Author

sleshchenko commented Feb 7, 2019

Added memoryLimit field to dockerimage tool model

@sleshchenko
Copy link
Member Author

Added mountSources field to dockerimage tool model

@skabashnyuk
Copy link
Contributor

LGTM

@sleshchenko sleshchenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

4 participants