Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving referenced files when building a factory from a link to raw content of the devfile #12798

Closed
metlos opened this issue Feb 28, 2019 · 0 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Feb 28, 2019

Description

Currently when creating using the factory to build a workspace from a link to a devfile content, the "links" to other files using the local attribute are not supported.

This could be improved and we could leverage the hierarchical nature of the URL to the devfile to try an locate those files.

This will of course still fail in cases like similar to "Test 3" in #12278 where the url to the devfile is not the same as to the rest of the codebase (e.g. https://pastebin.com/raw/d4wty8Q1) but it would work in a case where the URL would point to a view of the repository, like for example https://raw.githubusercontent.com/che-incubator/chectl/master/.devfile

@metlos metlos added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Feb 28, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Mar 6, 2019
@metlos metlos closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants