Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple dockerimage tools in Devfile #12875

Closed
sleshchenko opened this issue Mar 13, 2019 · 1 comment
Closed

Support multiple dockerimage tools in Devfile #12875

sleshchenko opened this issue Mar 13, 2019 · 1 comment
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Mar 13, 2019

Description

Support multiple dockerimage tools in Devfile.
We can not use dockerimage recipe for representation of dockerimage tool because workspace config can have only one dockerimage recipe. The possible solution here is to generate a k8s deployment for dockerimage tool and then merge multiple dockerimage related deployments to one deployment.

Implementation details

  1. The logic about parsing k8s/os recipe and provisioning some objects there should be extracted from KubernetesToolToWorkspaceConfigApplier after merge of https://github.com/eclipse/che/pull/12842/files#diff-433beefd65ee6f2da3b5fc799536bd3bR126.
  2. A dedicated pod should be provisioned to workspace config recipe, pod should contain:
  • image;
  • command;
  • args;
  • memoryLimit;
  • env vars;
  1. Workspace config should be provisioned with new machine config entry where we would provision the following configuration:
  • volumes (including projects volume if mountSources is specified);
  • endpoints.
    * We could convert this configuration to k8s/os objects as well, but it would be a tricky part that will duplicate a logic that is already implemented on Che Server side. I think that provisioning machine config and letting Che Server to do all needed work will be good enough.

P.S. Implementation details are not final decision but result of short investigate that was done.

@sleshchenko sleshchenko added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 13, 2019
@skabashnyuk skabashnyuk added team/platform severity/P1 Has a major impact to usage or development of the system. labels Mar 13, 2019
@sleshchenko
Copy link
Member Author

Short investigation was done and the result is described in Implementation details section of issue description.

@sleshchenko sleshchenko self-assigned this Mar 22, 2019
@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 22, 2019
@sleshchenko sleshchenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants