Show a confirmation dialog when Ctrl+W is pressed in the terminal

[sleshchenko]

Description

ctrl+w is the standard "kill word" (aka werase) hotkey in terminal, and it's weird to see Che Theia tab closed after trying to erase the last word. This issue is a feature request to show a confirmation dialog when Ctrl+W is pressed in the terminal.

Reproduction Steps

1. Start Che 7 Workspace.
2. Open terminal.
3. Press ctrl+w.
   Actual: Che Theia browser tab is closed.
   Expected: Ideal behavior would be the same as in native terminal - last word is erased, but I afraid whether it is possible to override such browser hotkey. So, at least a confirmation dialog should be shown before closing, because it's a typical thing when user press ctrl+w in terminal and does not to close tab.

[amisevsk]

This one has been bothering me for awhile as well -- I've closed a Che tab so many times :)

[azatsarynnyy]

Have you tried confirmExit preference?

[azatsarynnyy]

In Che Theia, the setting prevents reloading the page accidentally but doesn't prevent closing it.
In bare Theia, it works in both cases.

[slemeur]

so it sounds more like a bug @azatsarynnyy

[sleshchenko]

The setting of Always ask preference affects dashboard also even after workspace stopping.
@azatsarynnyy Do you think we need a bug for that?

Also, note that when I opened preferences - there was already set always but before I reloaded page without confirmation. I guess there is some bug in importing preferences for new workspace. I can investigate it more if needed.

[azatsarynnyy]

Do you think we need a bug for that?

I think it is a bug. At least, that setting shouldn't affect the dasboard behavior.

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[amisevsk]

Reopening this issue since I still hit this daily; capturing ctrl+w or at least popping a dialog should be the default -- we already catch F5 and other browser hotkeys. Anyone who has muscle memory for using ctrl+w in a terminal will be affected by this issue.

[amisevsk]

I'll fight che-bot if I have to.

[benoitf]

@amisevsk you need to remove stale as well

[amisevsk]

Thanks @benoitf :)