Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks of remote plugins are not redirected to corresponding container #13741

Closed
RomanNikitenko opened this issue May 15, 2019 · 9 comments
Closed
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@RomanNikitenko
Copy link
Member

Description

We have remotes plugins. I turned on the typescript plugin for my workspace and tried to run 'build' and 'watch' tasks for che-theia project, but they failed.
ProcessTaskRunner is used for running typescript task configurations, so tasks for remote plugins are not redirected to container of the plugin at the moment.

Reproduction Steps

  1. Create workspace using Che 7 Theia dev stack
  2. Turned on typescript plugin
  3. Start workspace and clone che-theia project
  4. Run 'detected' 'build' or 'watch' task using 'Terminal' => 'Run Tasks' menu
@RomanNikitenko RomanNikitenko changed the title Tasks are not redirected to corresponding container Tasks of remote plugins are not redirected to corresponding container May 15, 2019
@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 5, 2019
@tsmaeder
Copy link
Contributor

So which container are the tasks executed in and which container would you expect them to be executed in?

@RomanNikitenko
Copy link
Member Author

Tasks provided by remote plugins are executed in theia-ide container. I expect that they should be executed in a plugin container.

@tsmaeder tsmaeder mentioned this issue Sep 10, 2019
41 tasks
@tsmaeder tsmaeder mentioned this issue Sep 24, 2019
30 tasks
@tsmaeder tsmaeder mentioned this issue Oct 11, 2019
26 tasks
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@RomanNikitenko
Copy link
Member Author

/remove-lifecycle stale

@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented May 6, 2020

@ericwill this is one of the more serious problems we have mapping VS Code stuff to our workspace model: where do we run things like tasks, etc.
In the end, we can't know where to run tasks: for example, we might want to run a maven build on the dev machine, not the java plugin sidecar. I believe we should implement two things:

  1. Extend the theia task system to include a "target component" for every task. This will be a complicated undertaking
  2. Allow for che plugins to annotate the tasks contributed by vs code extensions with a hint where they should run.

@ericwill
Copy link
Contributor

ericwill commented May 6, 2020

@ericwill this is one of the more serious problems we have mapping VS Code stuff to our workspace model: where do we run things like tasks, etc.
In the end, we can't know where to run tasks: for example, we might want to run a maven build on the dev machine, not the java plugin sidecar. I believe we should implement two things:

1. Extend the theia task system to include a "target component" for every task. This will be a complicated undertaking

2. Allow for che plugins to annotate the tasks contributed by vs code extensions with a hint where they should run.

Thanks for the context, we should probably provide this feature sometime soon-ish.

@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2022
@che-bot che-bot closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants