Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace isn't accessible right after installing a plugin #13912

Closed
5 of 23 tasks
akurinnoy opened this issue Jul 18, 2019 · 6 comments · Fixed by eclipse-che/che-theia#372
Closed
5 of 23 tasks

Workspace isn't accessible right after installing a plugin #13912

akurinnoy opened this issue Jul 18, 2019 · 6 comments · Fixed by eclipse-che/che-theia#372
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@akurinnoy
Copy link
Contributor

akurinnoy commented Jul 18, 2019

Describe the bug

After installing a plugin listed in "Che plugin" panel I tried to restart the workspace by click on the popup and confirming that in dialog window. Instead of the workspace-loader page I got server error.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Click on "View" and then click on "Che Plugins"
  2. In "Che Plugins" panel click on "Install" button in the first plugin.
  3. Wait until plugin gets installed.
  4. Click on the green rectangular with text "Click here to apply changes ..." on the top of "Che Plugins" panel and then confirm your intention in modal dialog window.
  5. See the server error on the page.

Expected behavior

Workspace is loading and workspace-loader shows loading logs.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
$ minikube version
minikube version: v1.2.0
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-20T04:49:16Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:32:14Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Screen Recording 2019-07-18 at 15 45 23 2019-07-18 16_15_54

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@rhopp
Copy link
Contributor

rhopp commented Jul 19, 2019

@akurinnoy Before I get a chance to try that myself... Is there a workaround, or this results in completely unusable workspace?
Also you pointed you used latest version of che. Could you try with nightly if this bug still reproduces?

@akurinnoy
Copy link
Contributor Author

@rhopp workspace works well if you refresh the page.

I made a mistake - pointed wrong version of Che. I got the bug on nightly version. Description is updated.

@rhopp
Copy link
Contributor

rhopp commented Jul 19, 2019

Even the workaround is pretty simple (F5), this looks like a nasty bug. I would vote for fixing this in GA.

@rhopp rhopp added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. labels Jul 19, 2019
@rhopp rhopp added this to the 7.0.0 milestone Jul 19, 2019
@vitaliy-guliy
Copy link
Contributor

I have the same issue in Che on minikube

Screenshot from 2019-07-22 11-27-20

It looks something has changed on the backend. Now before refreshing the page plugin manager should wait a bit until workspace has been stopped completely.

Devfile I am using to create a workspace

metadata:
  name: che-theia-all
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
components:
  - mountSources: true
    endpoints:
      - name: theia-dev-flow
        attributes:
          protocol: http
          public: 'true'
        port: 3030
    memoryLimit: 4Gi
    type: dockerimage
    image: 'eclipse/che-theia-dev:next'
    alias: che-dev
  - id: redhat/vscode-yaml/latest
    type: chePlugin
  - id: che-incubator/typescript/latest
    memoryLimit: 2048M
    type: chePlugin
  - id: eclipse/che-theia/next
    type: cheEditor
    alias: theia-editor
  - id: redhat/php/latest
    type: chePlugin
apiVersion: 1.0.0
commands:
  - name: build ... DEV che-theia
    actions:
      - workdir: /projects/che-theia
        type: exec
        command: |
          yarn
        component: che-dev

@vitaliy-guliy
Copy link
Contributor

Sometimes I get 404
Screenshot from 2019-07-22 11-47-27

@l0rd l0rd added the team/ide2 label Jul 22, 2019
@l0rd l0rd changed the title Workspace doesn't restart after installing a plugin. Workspace isn't accessible right after installing a plugin Jul 23, 2019
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Jul 23, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 23, 2019

I have changed this issue title because the workspace is restarted successfully but the user is redirected too early and the app is not ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants