Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open terminal with non-patched images on OCP 4 fails #13977

Closed
l0rd opened this issue Jul 23, 2019 · 7 comments
Closed

Open terminal with non-patched images on OCP 4 fails #13977

l0rd opened this issue Jul 23, 2019 · 7 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Jul 23, 2019

Is your enhancement related to a problem? Please describe.

"CRI-O now has support for adding the entry of the user to the /etc/password if it does not exists in /etc/passwd".

The problem is that it creates an entry like this one on /etc/passwd:

1001360000:x:1001360000:0:1001360000 user:/project:/sbin/nologin

Hence Theia exec plugin uses the login shell /sbin/nologin to open a terminal and fails as described here.

Describe the solution you'd like

When the default login shell is /sbin/nologin use sh instead.

@benoitf
Copy link
Contributor

benoitf commented Jul 23, 2019

hello, is that the issue template is no longer working ?

@sunix sunix added area/editor/theia Issues related to the che-theia IDE of Che area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 23, 2019
@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

hello, is that the issue template is no longer working ?

I guess you can go bypass with https://github.com/eclipse/che/issues/new

@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

@AndrienkoAleksandr how hard would that be to fix that ? (use /bin/sh instead of /sbin/nologin) ?

@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

@l0rd @rhopp @tsmaeder @slemeur @nickboldt

This has to be 7.0.0 GA:

  • We will have many users who will run Che on ocp4
  • They will try to go beyond the samples and try their own containers
  • This should be an easy fix without to much risk

It would be a shame to loose these users with that bug.

@sunix
Copy link
Contributor

sunix commented Jul 24, 2019

estimation from @AndrienkoAleksandr : 1 day to fix that

@l0rd l0rd added this to the 7.1.0 milestone Jul 24, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Jul 24, 2019

That's a P1 but I have set 7.0.0. That means that @AndrienkoAleksandr should work on it only if he has no blockers assigned.

@l0rd l0rd modified the milestones: 7.1.0, 7.0.0 Jul 24, 2019
@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Jul 24, 2019
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Jul 29, 2019
@AndrienkoAleksandr AndrienkoAleksandr added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 29, 2019
@AndrienkoAleksandr
Copy link
Contributor

Should be fixed by eclipse-che/che-machine-exec#39

@AndrienkoAleksandr AndrienkoAleksandr removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants