Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability: Right-click Should not Execute Commands #13988

Closed
1 of 3 tasks
tsmaeder opened this issue Jul 24, 2019 · 3 comments
Closed
1 of 3 tasks

Usability: Right-click Should not Execute Commands #13988

tsmaeder opened this issue Jul 24, 2019 · 3 comments
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 24, 2019

The workspace view on the right side shows the various containers and the commands available for them. When I right-click on a command, it starts executing.

This is unexpected: right-click opens a context menu in the vast majority of cases. It should not execute the command

Che version

  • latest
  • nightly
  • other: please specify
@tsmaeder tsmaeder added the area/editor/theia Issues related to the che-theia IDE of Che label Jul 24, 2019
@vitaliy-guliy
Copy link
Contributor

We know about that and ready to find a solution.

Having a look at the Plugin API we can see that plugin writer can specify a command which will be executed when the tree item is selected. We use that field to handle clicking on the tree item.

In Theia right click leads to changing the selection, firing corresponding events with following execution of commands.
That's a main problem.

@vitaliy-guliy vitaliy-guliy changed the title Usability: Right-click Should now Execute Commands Usability: Right-click Should not Execute Commands Jul 24, 2019
@sunix sunix added kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 24, 2019
@nickboldt
Copy link
Contributor

Also related are #13989 and #13149 since a user would expect to be able to Run or Configure from a right-click context menu, not have the command execute.

@nickboldt nickboldt added this to the 7.2.0 milestone Jul 24, 2019
@nickboldt nickboldt removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 24, 2019
@gazarenkov gazarenkov removed this from the 7.2.0 milestone Oct 2, 2019
@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Feb 6, 2020
@azatsarynnyy
Copy link
Member

cannot reproduce
looks like already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

6 participants