Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Testing LSP features #14023

Closed
tsmaeder opened this issue Jul 25, 2019 · 2 comments
Closed

Investigate Testing LSP features #14023

tsmaeder opened this issue Jul 25, 2019 · 2 comments
Assignees
@tolusha
Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
Backlog - Languages

Comments

@tsmaeder
Copy link
Contributor

Investigate writing automated tests as requested in #13897

Since we don't have knowledge of vs code extension internals, it would make sense to attack testing at the level of the plugin API. We would have to write an extension that allows to script

  • setting up a workspace
  • invoking plugin api functions (like code assist)
  • intercepting answers

Ideally, we could run these tests headless.
@tsmaeder tsmaeder added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 25, 2019
@tsmaeder tsmaeder mentioned this issue Jul 25, 2019
Closed
20 tasks
@tolusha tolusha self-assigned this Aug 7, 2019
@tolusha tolusha added status/in-progress This issue has been taken by an engineer and is under active development. team/languages area/languages Issues related to Language extensions or plugins integration. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Aug 7, 2019
@tsmaeder tsmaeder mentioned this issue Aug 14, 2019
Closed
24 tasks
@tolusha tolusha removed the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Aug 23, 2019
@tolusha
Copy link
Contributor

tolusha commented Aug 23, 2019

All investigations are described here: #14025 (comment)

@tolusha tolusha closed this as completed Aug 23, 2019
@tsmaeder tsmaeder mentioned this issue Sep 3, 2019
Closed
@tsmaeder tsmaeder reopened this Sep 4, 2019
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 4, 2019

@tolusha there is a problem with the LSP tests: they go through the language client provider, which means they will no work for VS Code API-based language contributions.
The problem is that we have no way to address a particular extension when calling API: everything is directly registered with the Monaco editor (for example completion providers). I would figure we need to instrument the registration API somehow in order to be able to address a particular extensions when testing language features.

@tsmaeder tsmaeder added this to the Backlog - Languages milestone Sep 23, 2019
@thisHermit thisHermit mentioned this issue Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tolusha tolusha

Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
Backlog - Languages
Development

No branches or pull requests
2 participants
@tolusha @tsmaeder