Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Documentation for overriding all the involved images for the airgap scenario #14088

Closed
nickboldt opened this issue Jul 31, 2019 · 9 comments
Assignees
Labels
area/doc Issues related to documentation area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Milestone

Comments

@nickboldt
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

As noted in #13886 we can override many of the Che images at deploy time via a custom resource yaml.

  • cheImage
  • postgresImage
  • identityProviderImage
  • pvcJobsImage
  • devfileRegistryImage
  • pluginRegistryImage

But this does not include ALL the images. The following are missing:

  • Che Theia image
  • Che plugin broker image
  • Che JWT proxy
  • Che Theia endpoint runtime image
  • Che remote plugins (eg., openshift connector, kubernetes tooling, java8, java11)

Describe the solution you'd like

Add more fields to the CR, and have those supported when using chectl to deploy Che.

Additional context

This is in support of offline/airgap scenarios, where we can't just pull random container images from quay/rhcc, but need to set specific ones within an organization (or specific productized ones).

See also

@nickboldt nickboldt added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. labels Jul 31, 2019
@nickboldt nickboldt added this to the 7.1.0 milestone Jul 31, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 31, 2019
@davidfestal
Copy link
Contributor

In a number of cases, I assume that for now you can change them by simply adding the corresponding environment variable in the custom config map.
I did it just today for the plugin-broker docker image.
But sure, this is not integrated with chectl, and is not really easy to use

@benoitf benoitf added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 1, 2019
@slemeur slemeur changed the title chectl + cr.yaml should be able to overriding ALL images deployed via operator Installation should allow to set the value for all Che images Aug 2, 2019
@slemeur
Copy link
Contributor

slemeur commented Aug 2, 2019

Installations that is concerned by this issue are: from chectl and from operatorhub

@ibuziuk ibuziuk modified the milestones: 7.1.0, 7.x Aug 29, 2019
@ibuziuk ibuziuk added the severity/P2 Has a minor but important impact to the usage or development of the system. label Aug 29, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 29, 2019

@nickboldt please clarify why it is P1, moved to 7.x atm

@nickboldt nickboldt added the area/install Issues related to installation, including offline/air gap and initial setup label Sep 12, 2019
@nickboldt
Copy link
Contributor Author

nickboldt commented Sep 22, 2019

Need this for offline / airgap, so P1/blocker.

But sure, this is not integrated with chectl, and is not really easy to use

If we can't do full integration then at least a blog/doc with example would suffice for a first pass. But we need SOMETHING here for customers.

@nickboldt nickboldt added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. and removed severity/P1 Has a major impact to usage or development of the system. severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 22, 2019
@davidfestal
Copy link
Contributor

After issue #13886 (comment) is fixed, this issue should mainly consist in providing some scenario-oriented documentation, dedicated to the offline / airgap mode.
Do you agree @nickboldt ?

@nickboldt
Copy link
Contributor Author

Yes, that would be great for Che 7 and would work as the baseline from which to create CRW 2 docs too.

Related downstream issues:

@davidfestal davidfestal modified the milestones: 7.x, Backlog - Hosted Che Sep 23, 2019
@ibuziuk ibuziuk changed the title Installation should allow to set the value for all Che images [docs] Documentation for overriding all the involved images for the airgap scenario Sep 25, 2019
@ibuziuk ibuziuk removed this from the Backlog - Hosted Che milestone Sep 25, 2019
@ibuziuk ibuziuk added this to the 7.3.0 milestone Sep 25, 2019
@nickboldt
Copy link
Contributor Author

nickboldt commented Oct 2, 2019

Related issues:

And these older ones:

@ibuziuk
Copy link
Member

ibuziuk commented Oct 16, 2019

@nickboldt I'm going to close this one in favor of #14866
Are you ok with that ?

@nickboldt
Copy link
Contributor Author

Sure. 3 of the 5 related issues on this one are resolved too -- it's just the chectl issues that remain unresolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

No branches or pull requests

8 participants