Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to set boolean value for preferences via devfile #14131

Closed
5 of 23 tasks
tolusha opened this issue Aug 5, 2019 · 7 comments
Closed
5 of 23 tasks

Impossible to set boolean value for preferences via devfile #14131

tolusha opened this issue Aug 5, 2019 · 7 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@tolusha
Copy link
Contributor

tolusha commented Aug 5, 2019

Describe the bug

Impossible to set boolean value for preferences via devfile.
It is automatically converted into a string.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Add preferences into devfile
  preferences:
   some_attribute: false
  1. It is automatically converted into:
  preferences:
   some_attribute: 'false'
  1. Start a workspace
  2. Check user preferences:
{
   some_attribute: "false"
}
  1. The value of the attribute is treated as string instead of boolean

Expected behavior

Expected boolean value for an attribute.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

It is needed for #13698

@tolusha tolusha added kind/bug Outline of a bug - must adhere to the bug report template. area/devfile labels Aug 5, 2019
@slemeur slemeur mentioned this issue Aug 5, 2019
20 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 5, 2019
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 5, 2019
@benoitf benoitf added this to the 7.1.0 milestone Aug 5, 2019
@benoitf
Copy link
Contributor

benoitf commented Aug 5, 2019

feature issue is for 7.1.0 so putting the same milestone there

@benoitf
Copy link
Contributor

benoitf commented Aug 5, 2019

cc @skabashnyuk @ibuziuk

@sleshchenko
Copy link
Member

Seems it duplicates #13302 but the title definitely is more precise here )

@mshaposhnik
Copy link
Contributor

@tolusha am i correct - you mean the attributes of the root devfile object ? (there is no preferences field except the one in chePlugin type)?

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2019

@mshaposhnik
I mean in the preferences field of the chePlugin.

components:
-
  type: chePlugin
  reference: https://raw.githubusercontent.com/tolusha/plugins-registry/master/plugins/tolusha/cpptools/0.1/meta.yaml
  alias: cpp-plugin
  preferences:
    clangd.path: /usr/bin/clangd
    cdt.clangd.binaries.enable: false

@mshaposhnik
Copy link
Contributor

ok

@tolusha
Copy link
Contributor Author

tolusha commented Aug 16, 2019

#14174

@tolusha tolusha closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants