Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chectl] install.sh should provide switch for selecting installation path #14184

Closed
rhopp opened this issue Aug 9, 2019 · 4 comments
Closed
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@rhopp
Copy link
Contributor

rhopp commented Aug 9, 2019

Is your enhancement related to a problem? Please describe.

Currently, bash <(curl -sL https://www.eclipse.org/che/chectl/) --channel=next installs chectl into /usr/local/bin/chectl

For the purposes of CI usage, this might not be perfect and having option --install-path would be nice.

Describe the solution you'd like

Adding switch allowing user to install chectl to any directory:
bash <(curl -sL https://www.eclipse.org/che/chectl/) --channel=next --install-path=/home/user/bin for example

@rhopp rhopp added kind/enhancement A feature request - must adhere to the feature request template. area/chectl Issues related to chectl, the CLI of Che labels Aug 9, 2019
@rhopp rhopp added this to the 7.1.0 milestone Aug 9, 2019
@benoitf benoitf self-assigned this Aug 9, 2019
@benoitf
Copy link
Contributor

benoitf commented Aug 9, 2019

at the end, the script execute the binary, so it will check that in your case
/home/user/bin was added to the PATH

is it OK ?

@rhopp
Copy link
Contributor Author

rhopp commented Aug 9, 2019

I'm not sure if modifying user's PATH is something this script should do... Couldn't it instead of chectl version call ${INSTALL_PATH}/chectl version?

And if we would like to be really fancy, we could print some message if we found out, chectl is not on PATH like:
"Chectl is not on your PATH. If you want to add it, please execute PATH=${INSTALL_PATH}:$PATH"

@rhopp rhopp modified the milestones: 7.1.0, 7.x Aug 9, 2019
@rhopp rhopp added the severity/P2 Has a minor but important impact to the usage or development of the system. label Aug 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Feb 5, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2020
@benoitf benoitf added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2020
@benoitf benoitf removed their assignment Mar 11, 2020
@tolusha tolusha removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 21, 2022
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2022
@che-bot che-bot closed this as completed Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants