Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] React to Workspace Folder Changes #14365

Closed
tsmaeder opened this issue Aug 29, 2019 · 1 comment
Closed

[C#] React to Workspace Folder Changes #14365

tsmaeder opened this issue Aug 29, 2019 · 1 comment
Assignees
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next

Comments

@tsmaeder
Copy link
Contributor

In #14223, we found out that C# plugin works reads workspace roots at statup, but it does not handle changing workspace roots. We would need that support in order to merge the fix for #13427.

So this task is about reacting to didChangeWorkspaceFolders events and "do the right thing" (to be defined)

@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. team/languages area/languages Issues related to Language extensions or plugins integration. labels Aug 29, 2019
@tsmaeder tsmaeder changed the title React to Workspace Folder Changes [C#] React to Workspace Folder Changes Aug 29, 2019
@tsmaeder tsmaeder mentioned this issue Aug 29, 2019
41 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 29, 2019
@tsmaeder tsmaeder added severity/P1 Has a major impact to usage or development of the system. sprint/next and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 30, 2019
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 3, 2019

So the items to implement here would be:

  1. if a new "solution" is detected, pop up the "solution picker UI" (see [C#] Handle Multiple Solutions #14370) with the existing solution pre-selected
  2. of the currently open solution is removed from the workspace, offer to choose another solution
  3. when the last one is gone, stop the language server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next
Projects
None yet
Development

No branches or pull requests

3 participants