Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chectl must make sure that objects(like che-operator clusterrole) are up-to-date #14419

Closed
9 of 23 tasks
sleshchenko opened this issue Sep 4, 2019 · 4 comments
Closed
9 of 23 tasks

chectl must make sure that objects(like che-operator clusterrole) are up-to-date #14419

sleshchenko opened this issue Sep 4, 2019 · 4 comments
Assignees
@flacatus
Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.18

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Sep 4, 2019 •
edited by tolusha
Loading

Describe the bug

chectl must make sure that objects(like che-operator clusterrole) are up-to-date.
Currently, chectl only checks if che-operator clusterrole, clusterrolebinding exist and does not update them.
But it's possible that such resources are modified and should be updated on cluster as well to keep Che working (like the following PR eclipse-che/che-operator#66).
So, it's needed to make sure that chectl makes sure that resources are current, not just that they exist.
The minimal scope of this issue is che-operator role, rolebinding, clusterrole, clusterrolebidings but there can be other resources that must be kept up-to-date as well.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

It's pretty clear but if feel free to ask me to add detailed steps if needed.

Expected behavior

Che Resources are actual and Che works.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

https://issues.redhat.com/browse/CRW-987
https://issues.redhat.com/browse/CRW-967
https://issues.redhat.com/browse/CRW-1039
#14474
@benoitf benoitf added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. area/chectl Issues related to chectl, the CLI of Che severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 4, 2019
@benoitf benoitf modified the milestone: 7.2.0 Sep 4, 2019
@sleshchenko sleshchenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 5, 2019
@tsmaeder tsmaeder changed the title chectl must make sure that objects(like che-operator clusterrole) are actual chectl must make sure that objects(like che-operator clusterrole) are up-to-date Sep 9, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 9, 2019

@sleshchenko I had some trouble understanding the issue, so I tried to clarify the language.

@benoitf benoitf removed the status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. label Sep 9, 2019
@sleshchenko
Copy link
Member Author

Here are non-tested changes that should fix the described issue sleshchenko/chectl@a776c8f

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Feb 12, 2020 •
edited
Loading

Downstream issue: https://issues.redhat.com/browse/CRW-505

@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Jul 7, 2020
@tolusha tolusha modified the milestone: Backlog - Deploy Jul 8, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Jul 29, 2020
@tolusha tolusha mentioned this issue Jul 30, 2020
Closed
42 tasks
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.18 Aug 4, 2020
@flacatus flacatus self-assigned this Aug 5, 2020
@flacatus flacatus mentioned this issue Aug 19, 2020
Merged
@tolusha tolusha mentioned this issue Aug 19, 2020
Closed
58 tasks
@tolusha
Copy link
Contributor

tolusha commented Aug 25, 2020

Fixed by che-incubator/chectl@2fca137

We allows to deploy several Eclipse Che on a single cluster using --installer operator.
Every deployment will have it's own clusterrole and clusterrolebinding objects.
Besides this we check if CRD object is the same and throws an error if not.

@tolusha tolusha closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flacatus flacatus

Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.18
Development

No branches or pull requests
6 participants
@benoitf @dmytro-ndp @tolusha @sleshchenko @tsmaeder @flacatus