Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse/che-theia:next still contains @theia/cpp extension #14555

Closed
tolusha opened this issue Sep 16, 2019 · 4 comments
Closed

eclipse/che-theia:next still contains @theia/cpp extension #14555

tolusha opened this issue Sep 16, 2019 · 4 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@tolusha
Copy link
Contributor

tolusha commented Sep 16, 2019

Describe the bug

eclipse/che-theia:next still contains @theia/cpp extension that was excluded in this commit [1]

[1] eclipse-che/che-theia@992a059

Steps to reproduce

  1. docker pull eclipse/che-theia:next
  2. go into the container
$ ls /home/theia/node_modules/@theia/ | grep cpp
> cpp

Expected behavior

@theia/cpp extension shouldn't be present

Additional context

eclipse/che-theia:latest - doesn't contain the extension
if build eclipse/che-theia:next locally then @theia/cpp doesn't exist either

Is needed for

#13698

@tolusha tolusha added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che labels Sep 16, 2019
@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. team/ide2 labels Sep 16, 2019
@tsmaeder tsmaeder added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 25, 2019
@tsmaeder
Copy link
Contributor

Raising priority: we can't release cpp support without this.

@benoitf
Copy link
Contributor

benoitf commented Sep 25, 2019

the issue is that the PR can't be merged as happy path is failing to unrelated issues
eclipse-che/che-theia#441

@benoitf
Copy link
Contributor

benoitf commented Sep 25, 2019

eclipse-che/che-theia#449 should unblock

@mmorhun
Copy link
Contributor

mmorhun commented Sep 26, 2019

Done

@mmorhun mmorhun closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants