Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator-sdk generate k8s strips license out of generated files #14782

Closed
tomgeorge opened this issue Oct 4, 2019 · 3 comments
Closed

operator-sdk generate k8s strips license out of generated files #14782

tomgeorge opened this issue Oct 4, 2019 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.10

Comments

@tomgeorge
Copy link
Contributor

Is your task related to a problem? Please describe.

The generated type files in the Che Operator have a header referencing the Apache License. operator-sdk generate k8s deletes this header.

Describe the solution you'd like

Figure out how to add that license header back in the code-generation process.

Describe alternatives you've considered

Additional context
@tomgeorge tomgeorge added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 4, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 4, 2019
@tolusha tolusha added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label Oct 7, 2019
@tolusha
Copy link
Contributor

tolusha commented Oct 7, 2019

I don't know if it is a real issue.
@davidfestal @nickboldt ?

@tolusha tolusha added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Oct 7, 2019
@tomgeorge
Copy link
Contributor Author

tomgeorge commented Oct 7, 2019 •
edited
Loading

I think it is probably a low priority issue, but it's an issue. You shouldn't have to manually edit a generated file every it changes.

@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 7, 2019
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Feb 17, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Feb 17, 2020
This was referenced Feb 19, 2020
Closed
Merged
@tolusha
Copy link
Contributor

tolusha commented Feb 26, 2020

I've added script that generates cr/crd files, removes required and restores license header
eclipse-che/che-operator#180

@tolusha tolusha closed this as completed Feb 26, 2020
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.10.0 Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.10
Development

No branches or pull requests
3 participants
@tomgeorge @tolusha @che-bot