Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the che.infra.kubernetes.namespace.default property on update of che server #15119

Closed
metlos opened this issue Nov 6, 2019 · 1 comment
Closed
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@metlos
Copy link
Contributor

metlos commented Nov 6, 2019

Subtask of #14908

Is your enhancement related to a problem? Please describe.

Che 7.4.0 adds the ability to configure the namespace of a workspace using the new che.infra.kubernetes.namespace.default property. Che operator does not set that property.

Describe the solution you'd like

The operator should set this property to the same value as the legacy che.infra.kubernetes.namespace or che.infra.openshift.project. This will ensure smooth transition into the new way of configuring the workspace namespace.

Describe alternatives you've considered

Additional context

eclipse-che/che-operator#92 sets the new property on new installs. This issue is strictly about the update of an existing che installation using the operator.

@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Nov 6, 2019
@skabashnyuk skabashnyuk added this to the Backlog - Platform milestone Nov 6, 2019
@benoitf benoitf added the severity/P1 Has a major impact to usage or development of the system. label Nov 6, 2019
@skabashnyuk skabashnyuk modified the milestones: Backlog - Platform, 7.5.0 Nov 7, 2019
@skabashnyuk skabashnyuk moved this from To do to In progress in Platform-2019-11-26 Nov 8, 2019
@metlos
Copy link
Contributor Author

metlos commented Nov 8, 2019

I have verified that eclipse-che/che-operator#92 supports also the updates. When a new version of the operator is installed, it upgrades an existing che installation and updates the configmap with the correct value of the new environment variable.

@metlos metlos closed this as completed Nov 8, 2019
Platform-2019-11-26 automation moved this from In progress to Done Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
No open projects
Development

No branches or pull requests

3 participants