Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework che-theia branding to provide logo icon for plugin webview #15324

Closed
AndrienkoAleksandr opened this issue Nov 26, 2019 · 8 comments · Fixed by eclipse-che/che-theia#628
Closed

Rework che-theia branding to provide logo icon for plugin webview #15324

AndrienkoAleksandr opened this issue Nov 26, 2019 · 8 comments · Fixed by eclipse-che/che-theia#628
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone
7.10

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Nov 26, 2019 •
edited by azatsarynnyy
Loading

Is your task related to a problem? Please describe.

After change web-view eclipse-theia/theia#6465, webview doesn't have access to the resources outside plugin.

image

Describe the solution you'd like

We need to rework che-theia branding to provide logo icon for plugin web-view.
@AndrienkoAleksandr AndrienkoAleksandr added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Nov 26, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 26, 2019
@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Nov 26, 2019 •
edited
Loading

Related to #15283

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Nov 26, 2019
Merged
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. team/ide2 area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 26, 2019
@evidolob evidolob mentioned this issue Nov 27, 2019
Closed
20 tasks
@AndrienkoAleksandr
Copy link
Contributor Author

Hello, @benoitf we taked about fix for this issue on the planing. Proposed solution: we apply method to the che plugin api which should return logo content encoded in base64 and than we can easily display this icon in the welcome plugin. @benoitf Such solution is ok for you?

@benoitf
Copy link
Contributor

benoitf commented Nov 27, 2019

yes

@benoitf
Copy link
Contributor

benoitf commented Nov 27, 2019

do you have ETA of the size of the logo encoded in base64 ?

@AndrienkoAleksandr
Copy link
Contributor Author

@benoitf do you have ETA of the size of the logo encoded in base64 ?

~ 12K

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Dec 6, 2019
Closed
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Dec 9, 2019
@AndrienkoAleksandr AndrienkoAleksandr added the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 9, 2019
@AndrienkoAleksandr AndrienkoAleksandr removed their assignment Dec 9, 2019
@AndrienkoAleksandr AndrienkoAleksandr removed the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 9, 2019
@vitaliy-guliy
Copy link
Contributor

@l0rd could we assign it to Plugins team?

@mmorhun mmorhun mentioned this issue Jan 20, 2020
Closed
3 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Feb 3, 2020
Closed
20 tasks
@benoitf benoitf mentioned this issue Feb 6, 2020
Closed
@azatsarynnyy azatsarynnyy self-assigned this Feb 11, 2020
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 11, 2020
This was referenced Feb 17, 2020
Merged
Closed
@nickboldt nickboldt added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. area/productization and removed severity/P1 Has a major impact to usage or development of the system. labels Feb 21, 2020
@nickboldt
Copy link
Contributor

This is a blocker for CodeReady Workspaces 2.1 and a regression over 2.0.

Please escalate this so we can get it into 7.9.1, as this is a terrible OOTB visual experience.

Alternatively, please provide a way to suppress the icon entirely as it's really not that meaningful or needed.

BTW I thought 7.9.0 was supposed to be about hardening and UX fixes. How did this obvious UX problem fall through the cracks for 3 months?

@ghost
Copy link

ghost commented Feb 24, 2020

@nickboldt how exactly is this a blocker? I don't really want to hear people's own opinion and musings but we have an agreement that blocker means 'Causes system to crash and be non-recoverable or prevents Che developers from working on Che code'. If we all start barging in with our ideal 'blocker' definition it will get pretty crowded.

And it didn't fall through any crack - it was just not prioritized. If you think it should have been you are most welcome to join us when we prioritize as we are good listeners.

@azatsarynnyy azatsarynnyy added this to the 7.10.0 milestone Feb 25, 2020
@azatsarynnyy azatsarynnyy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 25, 2020
@nickboldt nickboldt mentioned this issue Feb 25, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
7.10
Development

Successfully merging a pull request may close this issue.

Rework white-labeling according to the upstream Theia changes on WebViews eclipse-che/che-theia
7 participants
@nickboldt @benoitf @l0rd @azatsarynnyy @vitaliy-guliy @AndrienkoAleksandr @che-bot