Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate directory specifying multiple projects in a devfile. #15607

Closed
Mbd06b opened this issue Jan 6, 2020 · 9 comments
Closed

Duplicate directory specifying multiple projects in a devfile. #15607

Mbd06b opened this issue Jan 6, 2020 · 9 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@Mbd06b
Copy link

Mbd06b commented Jan 6, 2020

Is there a way with a multi-project devfile to not duplicate the root of a project already defined in source control?

Gitlab / github
image

devfile ( it's a bit of a mess, but I'm trying different things)

projects:
  - name: parent
    source:
      location: 'https://gitlab.example.com/User/project.git'
      type: git
      sparseCheckoutDir: /parent/
    clonePath: projects
  - name: config-service
    source:
      location: 'https://gitlab.example.com/User/project.git'
      type: git
      sparseCheckoutDir: /config-service/
    clonePath: ''
  - name: gateway-service
    source:
      location: 'https://gitlab.example.com/User/project.git'
      type: git
      sparseCheckoutDir: /gateway-service/
    clonePath: projects
  - name: discovery-service
    source:
      location: 'https://gitlab.example.com/User/project.git'
      type: git
      sparseCheckoutDir: /discovery-service*

Workspace RESULT: Duplicated project root directory when using sparseCheckoutDir to add a project in source control.
image

che version 7.6.0

@Mbd06b Mbd06b added the kind/question Questions that haven't been identified as being feature requests or bugs. label Jan 6, 2020
@skabashnyuk
Copy link
Contributor

@Mbd06b that looks like a bug. Can you please help me to organize the test repository and test devfile to make sure we are talking about the same thing.

@skabashnyuk skabashnyuk added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach area/devfile labels Jan 6, 2020
@Mbd06b
Copy link
Author

Mbd06b commented Jan 6, 2020

@skabashnyuk
here's a remote of the actual repository... (notice the project directories at the root)
https://github.com/Mbd06b/bright

here's the devfile
https://github.com/Mbd06b/bright/blob/master/devfile.yaml

Above is the screenshot of what results in the Theia worskpace, directory paths...
projects/config-service/config-service/src
projects/discovery-service/discovery-service/src
...

Here are some related issues where I think this feature was added.
Discussion: #13671
Feature Merge: #14823

@mmorhun maybe you can weigh in here and determine if this is a bug or just me?

@skabashnyuk skabashnyuk added area/editor/theia Issues related to the che-theia IDE of Che and removed area/devfile labels Jan 8, 2020
@mmorhun
Copy link
Contributor

mmorhun commented Jan 10, 2020

@Mbd06b I've just tried your devfile, it's indeed a bug. Thank you for reporting.

@mmorhun mmorhun added kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. and removed kind/question Questions that haven't been identified as being feature requests or bugs. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Jan 10, 2020
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 31, 2020
@che-bot
Copy link
Contributor

che-bot commented Jul 29, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2020
@Mbd06b
Copy link
Author

Mbd06b commented Jul 30, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

/remove-lifecycle stale

I need to re-test this to see if it still happening.

This issue is really important for eclipse-che to ease microservice development for teams with a mono-repo.

@mmorhun mmorhun removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2020
@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Aug 3, 2020
@azatsarynnyy
Copy link
Member

I've updated area to plugins as it's related to Che Theia Workspace Plugin
cc @ericwill

@sunix
Copy link
Contributor

sunix commented Aug 11, 2020

Would #15347 work as a fix to that one?
It looks like we want to clone only once here, but display specific subfolders

@Mbd06b
Copy link
Author

Mbd06b commented Aug 23, 2020

This epic looks to be related to this issue. #15529

@che-bot
Copy link
Contributor

che-bot commented Feb 24, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2021
@che-bot che-bot closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants