Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedded OAuth authentication model default for both singe and multiuser che #15672

Closed
skabashnyuk opened this issue Jan 13, 2020 · 0 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jan 13, 2020

Is your task related to a problem? Please describe.

At this moment there are two models of how OAuthAPI is made in Eclipse Che.

  1. EmbeddedOAuthAPI - used in single-user che. In this case, we have the ability to configure GitHubOAuthAuthenticator with clientID and clientSecret to be able to get github tokens from OAuthAuthenticationService
  2. DelegatedOAuthAPI - use in multy-user Che. In this mode, all OAuth activities delegated to Keycloak that is configured with Che. To be able to get an OAuth token user has to provide a valid keycloak token.

Now with Che-Theia we have an issue #14217 . It happens because we have no mechanism to convert machine-token to keycloak

Describe the solution you'd like

  1. Set Embedded mode by default for single and multi-user che.
  2. Provide an ability to configure Delegated mode.
  3. If Embedded is set up and github's clientID and clientSecret are set for che-operator then correctly configure GitHubOAuthAuthenticator

Describe alternatives you've considered

n/a

Additional context

n/a

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform severity/P1 Has a major impact to usage or development of the system. labels Jan 13, 2020
@skabashnyuk skabashnyuk added this to To do in Platform-2020-01-28 via automation Jan 14, 2020
@skabashnyuk skabashnyuk added this to the 7.8.0 milestone Jan 14, 2020
@skabashnyuk skabashnyuk moved this from To do to In progress in Platform-2020-01-28 Jan 14, 2020
@skabashnyuk skabashnyuk self-assigned this Jan 14, 2020
@skabashnyuk skabashnyuk moved this from In progress to Review in progress in Platform-2020-01-28 Jan 17, 2020
@skabashnyuk skabashnyuk modified the milestones: 7.8.0, Backlog - Platform Jan 29, 2020
@skabashnyuk skabashnyuk removed this from Review in progress in Platform-2020-01-28 Jan 29, 2020
@skabashnyuk skabashnyuk added this to To do in Platform-2020-03-10 via automation Feb 25, 2020
Platform-2020-03-10 automation moved this from To do to Done Feb 25, 2020
@dmytro-ndp dmytro-ndp mentioned this issue Mar 13, 2020
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
No open projects
Development

No branches or pull requests

1 participant