Update helm chart to use RollingUpdate strategy

[dmytro-ndp]

Is your task related to a problem? Please describe.

It's possible to setup Recreate update strategy of Che Server deployment using deploy_che.sh script. This strategy is default in the deploy_che.sh and it has --rolling option to setup Rolling update strategy.

At the same time:

• there are no neither --rolling or --recreate options in chectl;
• che-operator configures che-server to use Rolling update strategy by default, and che-operator seems doesn't have an option to setup Recreate update strategy.

[l0rd]

@dmytro-ndp can you please clarify why this is important for you? I have set severity/P2 because I am considering that RollingUpdate StrategyType should be fine for every scenario but I am missing what's the scenario you have in mind so I may be wrong.

[dmytro-ndp]

@l0rd: we are officially supporting recreate update strategy for che6/CRW 1.x.
Recreate strategy is also default for Che 7 deployed to minikube by using helm charts, which is inconsistent with operator installer.
Anyway, feel free to close the issue with won't fix resolution.

[l0rd]

@dmytro-ndp we should fix the inconsistency. We should not add the --rolling/--recreate option if RollingUpdate works for every user scenario.

@skabashnyuk is there a reason why we use Recreate strategy for wsmaster by default on helm chart and deploy.sh but not on the operator? Would it be an issue if we set RollingUpdate by default everywhere?

[dmytro-ndp]

@l0rd: well, I didn't mention deploy_che.sh because we are getting rid of it (#13888).

[skabashnyuk]

@l0rd

Is there a reason why we use Recreate strategy for wsmaster by default on helm chart and deploy.sh but not on the operator?

I'm not aware of that.

Would it be an issue if we set RollingUpdate by default everywhere?

It should not.

[tolusha]

@dmytro-ndp
Do we still need this?

[l0rd]

@tolusha we still have to fix the inconsistency between the deployment strategies of Che helm chart (recreate) and Che operator (rollingUpdate). RollingUpdate should be the default for both.

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.